Refactor code style and configuration files - #65
Conversation
- Updated import statements to use double quotes for consistency across multiple files. - Refactored functions in `parseProgress.ts`, `results.ts`, `retentive.ts`, `simpleRetry.ts`, `buildLibrary.ts`, `parseFasta.ts`, and `parseRepseqioLibrary.ts` for improved readability and consistency. - Added VSCode configuration files for recommended extensions and formatting settings. - Introduced `.oxfmtrc.json` and `.oxlintrc.json` files in multiple directories to standardize formatting and linting configurations.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the overall code quality, consistency, and developer experience. It introduces standardized formatting and linting configurations, enhances VSCode support, and refactors code for better readability. These changes aim to create a more maintainable and developer-friendly codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the project's development tooling by migrating from ESLint to Oxc for linting and formatting, integrating ts-builder for build and check scripts, and updating related package dependencies and configurations across model, test, and ui modules. Additionally, string literals in many TypeScript/Vue files were converted from single to double quotes, and code formatting was adjusted for consistency. The review comments highlight a high-severity issue where a null check is needed for the newHandle object in ui/src/ExportRawBtn/ExportRawBtn.vue to prevent errors if a user cancels a file save dialog. Medium-severity suggestions include simplifying a regex in model/src/progress.ts for better readability and adding comments or checks for LocalImportFileHandle type assertions in ui/src/pages/BuildLibraryPanel.vue and ui/src/pages/SettingsPanel.vue for improved code clarity and safety.
parseProgress.ts,results.ts,retentive.ts,simpleRetry.ts,buildLibrary.ts,parseFasta.ts, andparseRepseqioLibrary.tsfor improved readability and consistency..oxfmtrc.jsonand.oxlintrc.jsonfiles in multiple directories to standardize formatting and linting configurations.