Skip to content

Refactor code style and configuration files - #65

Open
AStaroverov wants to merge 2 commits into
mainfrom
feat/migrate-to-oxc
Open

Refactor code style and configuration files#65
AStaroverov wants to merge 2 commits into
mainfrom
feat/migrate-to-oxc

Conversation

@AStaroverov

Copy link
Copy Markdown
  • Updated import statements to use double quotes for consistency across multiple files.
  • Refactored functions in parseProgress.ts, results.ts, retentive.ts, simpleRetry.ts, buildLibrary.ts, parseFasta.ts, and parseRepseqioLibrary.ts for improved readability and consistency.
  • Added VSCode configuration files for recommended extensions and formatting settings.
  • Introduced .oxfmtrc.json and .oxlintrc.json files in multiple directories to standardize formatting and linting configurations.

- Updated import statements to use double quotes for consistency across multiple files.
- Refactored functions in `parseProgress.ts`, `results.ts`, `retentive.ts`, `simpleRetry.ts`, `buildLibrary.ts`, `parseFasta.ts`, and `parseRepseqioLibrary.ts` for improved readability and consistency.
- Added VSCode configuration files for recommended extensions and formatting settings.
- Introduced `.oxfmtrc.json` and `.oxlintrc.json` files in multiple directories to standardize formatting and linting configurations.
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the overall code quality, consistency, and developer experience. It introduces standardized formatting and linting configurations, enhances VSCode support, and refactors code for better readability. These changes aim to create a more maintainable and developer-friendly codebase.

Highlights

  • Code Style Consistency: Ensured consistent code style by updating import statements to use double quotes and refactoring functions for improved readability across multiple TypeScript files.
  • Standardized Configuration: Introduced .oxfmtrc.json and .oxlintrc.json files in multiple directories to standardize formatting and linting configurations, enhancing code quality and maintainability.
  • Enhanced VSCode Support: Added VSCode configuration files (extensions.json and settings.json) to recommend extensions and formatting settings, streamlining the development experience for contributors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's development tooling by migrating from ESLint to Oxc for linting and formatting, integrating ts-builder for build and check scripts, and updating related package dependencies and configurations across model, test, and ui modules. Additionally, string literals in many TypeScript/Vue files were converted from single to double quotes, and code formatting was adjusted for consistency. The review comments highlight a high-severity issue where a null check is needed for the newHandle object in ui/src/ExportRawBtn/ExportRawBtn.vue to prevent errors if a user cancels a file save dialog. Medium-severity suggestions include simplifying a regex in model/src/progress.ts for better readability and adding comments or checks for LocalImportFileHandle type assertions in ui/src/pages/BuildLibraryPanel.vue and ui/src/pages/SettingsPanel.vue for improved code clarity and safety.

Comment thread ui/src/ExportRawBtn/ExportRawBtn.vue
Comment thread model/src/progress.ts
Comment thread ui/src/pages/BuildLibraryPanel.vue
Comment thread ui/src/pages/SettingsPanel.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant