Skip to content

Set default block label - #33

Open
mzueva wants to merge 2 commits into
mainfrom
mzueva/default-block-label
Open

Set default block label#33
mzueva wants to merge 2 commits into
mainfrom
mzueva/default-block-label

Conversation

@mzueva

@mzueva mzueva commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Set default block label

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @mzueva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the default label used for blocks across the application, ensuring consistency between the core model definition and the user interface. The defaultBlockLabel is now uniformly set to 'Select Dataset', replacing previous variations. This change improves clarity and user experience by providing a consistent default prompt. Accompanying these functional changes are routine dependency updates to keep the project's libraries current.

Highlights

  • Default Block Label Update (Model): The defaultBlockLabel for the platforma block model in model/src/index.ts has been updated from an empty string to 'Select Dataset'.
  • Default Block Label Update (UI): The default defaultBlockLabel in the UI application's initialization (ui/src/app.ts) has been changed from 'Select Clonotype Definition' to 'Select Dataset'.
  • Dependency Updates: Several @platforma-sdk packages (model, test, ui-vue), @milaboratories packages (pf-driver, pl-middle-layer, uikit), and @babel packages (parser, types) have been updated to newer versions in pnpm-lock.yaml and pnpm-workspace.yaml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default block label to 'Select Dataset' in both the model definition and the UI initialization logic. The changes also include updates to various dependencies. While the change correctly unifies the default label, I've identified an opportunity to improve maintainability by removing redundant code. My review includes one suggestion to remove a now-superfluous default value assignment in the UI code, ensuring that the model remains the single source of truth.

Comment thread ui/src/app.ts
const app = useApp();
app.model.args.customBlockLabel ??= '';
app.model.args.defaultBlockLabel ??= 'Select Clonotype Definition';
app.model.args.defaultBlockLabel ??= 'Select Dataset';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line is redundant because the default value for defaultBlockLabel is now correctly set in the block's model definition (model/src/index.ts). To ensure there's a single source of truth and prevent future inconsistencies, it's best to remove this fallback from the UI code.

For consistency, the same principle applies to customBlockLabel on the preceding line, which could also be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant