v1.8: focus, craft, visual clarity, and micro-cinematics - #1
Draft
pinkysworld wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
art:checkwork withoutXAI_API_KEYPlayer impact
The game keeps its existing historical and mechanical depth while making the daily objective, treatment choices, consequences, travel decisions, and management relationships easier to understand. Existing art is shown at more useful sizes, and the optional cinematic layer adds short transitions without blocking game state.
Validation
npx tsc --noEmitnpm test— 70 files / 860 testsnpm run buildnpm run art:checkwithout an API keygit diff --checkKnown review follow-up
The current scene-level promise catches preserve navigation when a session-once cinematic is requested again, but the central helper can still call
finish()beforeonKeyis initialized and raiseReferenceError: Cannot access 'onKey' before initialization. The procedure pilot is also the weakest visual clip and should be regenerated when the video API is available. This PR remains draft so those points are explicit before merge.Private
ART_*.mdproduction briefs andprogress.mdremain gitignored and were not published.