feat(parser): legend rule exemption for commanders you control#3430
Open
kiannidev wants to merge 2 commits into
Open
feat(parser): legend rule exemption for commanders you control#3430kiannidev wants to merge 2 commits into
kiannidev wants to merge 2 commits into
Conversation
Closes phase-rs#3423. Parser + unit tests for commander-scoped legend-rule exemption. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
2 tasks
Drop cross-PR opponent-search and kicked-spell tests that caused compile and runtime failures on this branch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3423. Parses
"The \"legend rule\" doesn't apply to commanders you control."intoLegendRuleDoesntApplywith anIsCommandercontroller-scoped filter.Changes
parse_legend_rule_scope"commanders"armImplementation method (required)
/engine-implementer— parser-only scope extensionCR references
CR 704.5j, CR 903.3
Verification
cargo test -p engine static_legend_rule_commanders --libMade with Cursor