Skip to content

feat(engine): legend rule integration guardrail test#3432

Merged
matthewevans merged 1 commit into
phase-rs:mainfrom
kiannidev:feat/issue-3425-legend-integration
Jun 16, 2026
Merged

feat(engine): legend rule integration guardrail test#3432
matthewevans merged 1 commit into
phase-rs:mainfrom
kiannidev:feat/issue-3425-legend-integration

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

Closes #3425. Adds an integration test ensuring duplicate same-name legendaries trigger ChooseLegend through the GameScenario → SBA path.

Changes

Implementation method (required)

  • Not /engine-implementer — integration test only

CR references

CR 704.5j

Verification

  • cargo test -p engine --test integration issue_3425

Made with Cursor

Closes phase-rs#3425. Adds GameScenario integration test for duplicate-legendary SBA choice.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev kiannidev requested a review from matthewevans as a code owner June 16, 2026 00:02
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@matthewevans matthewevans self-assigned this Jun 16, 2026

@matthewevans matthewevans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Control-case integration guardrail (CR 704.5j): two duplicate legendaries with no exemption must trigger ChooseLegend through the real GameScenario -> check_state_based_actions path. Discriminating, complements the exemption-suppression unit tests landed in #3429. Verified passing on local merge of origin/main on warm target. Closes #3425.

@matthewevans matthewevans added the test Add tests label Jun 16, 2026
@matthewevans matthewevans added this pull request to the merge queue Jun 16, 2026
@matthewevans matthewevans removed their assignment Jun 16, 2026
Merged via the queue into phase-rs:main with commit ae7dc82 Jun 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Add tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(engine): legend rule exemption integration scenarios

2 participants