feat(engine): legend rule integration guardrail test#3432
Merged
matthewevans merged 1 commit intoJun 16, 2026
Conversation
Closes phase-rs#3425. Adds GameScenario integration test for duplicate-legendary SBA choice. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
matthewevans
approved these changes
Jun 16, 2026
matthewevans
left a comment
Member
There was a problem hiding this comment.
Control-case integration guardrail (CR 704.5j): two duplicate legendaries with no exemption must trigger ChooseLegend through the real GameScenario -> check_state_based_actions path. Discriminating, complements the exemption-suppression unit tests landed in #3429. Verified passing on local merge of origin/main on warm target. Closes #3425.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3425. Adds an integration test ensuring duplicate same-name legendaries trigger
ChooseLegendthrough the GameScenario → SBA path.Changes
issue_3425_legend_rule_exemption_scopes.rscontrol-case testImplementation method (required)
/engine-implementer— integration test onlyCR references
CR 704.5j
Verification
cargo test -p engine --test integration issue_3425Made with Cursor