Remove vim-style keybindings (hjkl) from navigation - #32
Merged
Conversation
- Remove h/j/k/l as movement aliases from world map (HJKL conflicts) - Remove j/k from Menu, charCreate list/skills navigation (HJKL; j also globally intercepted to open Jukebox in most game states) - Remove k/K from Jukebox up-navigation (HJKL) - Reorder Menu.handleKey so explicit opt.key shortcuts are checked before WASD navigation keys, fixing s="Save Game" being shadowed by s=move-down https://claude.ai/code/session_01PEoMNt9CCkZeuBTjYM9Y9y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for vim-style navigation keybindings (hjkl) across the codebase, standardizing on arrow keys and WASD for movement controls.
Summary
Vim-style keybindings (h/j/k/l for left/down/up/right navigation) have been removed from all UI components. The codebase now consistently uses arrow keys and WASD as the primary alternative navigation methods.
Key Changes
Implementation Details
The Menu.ts refactoring also improves key handling priority:
This ensures that option-specific shortcuts cannot be shadowed by navigation keybindings.
https://claude.ai/code/session_01PEoMNt9CCkZeuBTjYM9Y9y