Skip to content

hierarchy_fix: prevent superseded parent from replacing self-references in the hierarchy #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
missinglink merged 1 commit into from
Jul 8, 2020
Merged

hierarchy_fix: prevent superseded parent from replacing self-references in the hierarchy #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sqlite/fix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ module.exports.hierarchies = (db, options) => {
}

// fix orphaned hierarchies
const placetype = feature.getPlacetype(feat)
const hierarchies = _.get(feat, 'properties.wof:hierarchy', [])
_.forEach(hierarchies, (hierarchy, branch) => {
_.forEach(hierarchy, (hierarchyId, key) => {
Expand All @@ -116,8 +117,15 @@ module.exports.hierarchies = (db, options) => {
console.error(`${id} has an incorrect ${key}, replacing ${hierarchyId} with ${replacementKey}=${replacement.id}`)

// handle the case where the placetype changed when superseded
if (key !== replacementKey) { _.unset(feat, `properties.wof:hierarchy[${branch}][${key}]`) }
if (key !== replacementKey) {
_.unset(feat, `properties.wof:hierarchy[${branch}][${key}]`)
reindex = true
}

// do not update self-references (those with the same placetype as the record itself)
if (replacement.placetype === placetype) { return }

// update hierarchy
_.set(feat, `properties.wof:hierarchy[${branch}][${replacementKey}]`, replacement.id)
reindex = true
}
Expand Down