hierarchy_fix: prevent superseded parent from replacing self-references in the hierarchy - #22
Merged
Merged
Conversation
…erences in the hierarchy
Member
Author
|
Member
|
It's funny reading each of your PRs here as you find more and more "interesting" edge cases and uncommon issues. Seems like WOF data is very inherently hard to keep consistent, even though its hierarchy is powerful. Good to see we are at least chipping away at it with some helpful automation :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following on from #21 I caught a fairly uncommon case where a document A has a parent X superseded by Y.
The problem is that if A & Y have the same placetype then the self-reference was being incorrectly replaced.
eg: whosonfirst-data/whosonfirst-data-admin-ca@505cc0e#diff-7e8b7130e6db85a8e6d8fad892353ee8