Skip to content

fix(store): don't corrupt manifest MinVersion during packaging #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulocorcino merged 1 commit into from
Jul 7, 2026
Merged

fix(store): don't corrupt manifest MinVersion during packaging #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packaging/msix/AppxManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<Identity
Name="__IDENTITY_NAME__"
Publisher="__PUBLISHER_ID__"
Version="0.1.0.0"
Version="__VERSION__"
ProcessorArchitecture="x64" />

<Properties>
Expand Down
6 changes: 3 additions & 3 deletions packaging/msix/build-msix.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ $manifest = Get-Content (Join-Path $scriptDir "AppxManifest.xml") -Raw
$manifest = $manifest.Replace("__IDENTITY_NAME__", $IdentityName)
$manifest = $manifest.Replace("__PUBLISHER_ID__", $PublisherId)
$manifest = $manifest.Replace("__PUBLISHER_DISPLAY_NAME__", $PublisherDisplayName)
# Case-sensitive so it targets Identity's Version="..." and NOT the lowercase
# version="1.0" in the <?xml ... ?> declaration.
$manifest = $manifest -creplace 'Version="[\d.]+"', "Version=`"$Version`""
# Token replace (not regex) so we only touch Identity's Version and never the
# <?xml version=...?> declaration or TargetDeviceFamily Min/MaxVersion.
$manifest = $manifest.Replace("__VERSION__", $Version)
Set-Content -Path (Join-Path $layout "AppxManifest.xml") -Value $manifest -Encoding UTF8

# --- 4. Pack -----------------------------------------------------------------
Expand Down