fix(store): don't corrupt manifest MinVersion during packaging - #51
Merged
Conversation
…rsion The -creplace 'Version="..."' also matched TargetDeviceFamily MinVersion, rewriting it to the package version (0.1.0.0). Partner Center then rejected the upload (MinVersion <= 10.0.17134.0). Replace an explicit __VERSION__ token in the Identity element instead, leaving MinVersion (10.0.17763.0) and the XML declaration untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partner Center rejected the uploaded MSIX: "targets Windows MinVersion <= 10.0.17134.0".
Cause: build-msix.ps1 used `-creplace 'Version="[\d.]+"'` to set the Identity
version, which also matched `TargetDeviceFamily MinVersion="10.0.17763.0"` and
rewrote it to the package version (0.1.0.0). Fix: replace an explicit
`VERSION` token in the Identity element instead, leaving MinVersion and the
XML declaration untouched. Verified the rebuilt package has MinVersion=10.0.17763.0.
🤖 Generated with Claude Code