SMALLFIX: Fix Liberty writer for slash and dollar bus names#464
Open
akashlevy wants to merge 1 commit into
Open
SMALLFIX: Fix Liberty writer for slash and dollar bus names#464akashlevy wants to merge 1 commit into
akashlevy wants to merge 1 commit into
Conversation
Round-trip pin/bus names that contain '/' by stripping STA escape backslashes on write, quote bus_type values, and accept '$' in Liberty lexer tokens so dollar-prefixed bus names parse. Co-authored-by: Cursor <cursoragent@cursor.com>
akashlevy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portStaToLibertyhelper to strip STA escape backslashes when writing Liberty names.bus_typevalues on write.$in Liberty lexerTOKENso dollar-prefixed bus/type names parse.liberty_write_escaped_namesround-trip regression (slash names +$vol_ts_newbus).Motivation
Port/bus names containing
/were written with STA escapes that Liberty cannot round-trip, and unquoted/$-prefixed bus names failed to parse or were written incorrectly.Combines Silimate fixes for escaped slash names and dollar-bus quoting.
Test plan
./regression liberty_write_escaped_names(local)Made with Cursor