Skip to content

fix(security): disable Liquid template file access #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thibault1818 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): disable Liquid template file access #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/infrastructure/template/template-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ export class LiquidTemplateEngine implements ITemplateEngine {
this.engine = new Liquid({
strictFilters: false,
strictVariables: false,
fs: {
exists: async () => false,
readFile: async () => { throw new Error('Liquid file includes are disabled'); },
existsSync: () => false,
readFileSync: () => { throw new Error('Liquid file includes are disabled'); },
resolve: (_root: string, file: string) => file,
dirname: (file: string) => file,
sep: '/',
},
});
}
return this.engine;
Expand Down
17 changes: 17 additions & 0 deletions test/unit/infrastructure/template-engine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,23 @@ describe('LiquidTemplateEngine timeout', () => {
});
});

describe('LiquidTemplateEngine file access', () => {
const engine = new LiquidTemplateEngine();
const ctx = buildPromptContext(makeTask(), makeAgent(), 1, '/workspace', DEFAULT_CONFIG);

it.each([
'{% include "/etc/passwd" %}',
'{% include "../secret.txt" %}',
'{% render "/etc/passwd" %}',
])('rejects file-backed tag: %s', async (template) => {
await expect(engine.render(template, ctx)).rejects.toThrow();
});

it('rejects dynamic include paths', async () => {
await expect(engine.render('{% assign path = "/etc/passwd" %}{% include path %}', ctx)).rejects.toThrow();
});
});

describe('LiquidTemplateEngine with retry context', () => {
const engine = new LiquidTemplateEngine();

Expand Down