You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
disable LiquidJS filesystem access for ORCH prompt templates
reject absolute, relative, dynamic, include, and render file references
preserve normal in-memory variable and filter rendering
Threat
Prompt templates can be influenced by repository configuration. Liquid file-backed tags could read host files and place their contents into an agent prompt. The custom filesystem implementation fails closed so templates cannot access local files.
Test Plan
npm ci --ignore-scripts
npm test -- test/unit/infrastructure/template-engine.test.ts (41 passed)
npm run typecheck
npm test (127 files, 2095 passed, 2 skipped)
npm run build
npm audit (0 vulnerabilities)
git diff --check
Limits
This PR only closes template filesystem access. It does not include the role workflow, adapter changes, package metadata, publishing changes, fork links, or generated dist files.
Reviewed at f09c917. I found no blocking injection or security issue in this change.
The PR is correctly scoped and hardens the existing LiquidTemplateEngine instead of introducing a parallel rendering path. I verified that absolute, relative, dynamic, Windows-style, include, render, layout, and inline-Liquid file references fail closed. Context values are rendered once and are not reinterpreted as Liquid, and prototype properties such as constructor and __proto__ remain inaccessible.
This is safe to merge. A non-blocking improvement would be to add explicit regression cases for layout, inline-Liquid includes, and Windows paths to the committed test suite.
The repository should also run its real CI checks on this PR; currently GitHub only reports the welcome job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Threat
Prompt templates can be influenced by repository configuration. Liquid file-backed tags could read host files and place their contents into an agent prompt. The custom filesystem implementation fails closed so templates cannot access local files.
Test Plan
npm ci --ignore-scriptsnpm test -- test/unit/infrastructure/template-engine.test.ts(41 passed)npm run typechecknpm test(127 files, 2095 passed, 2 skipped)npm run buildnpm audit(0 vulnerabilities)git diff --checkLimits
This PR only closes template filesystem access. It does not include the role workflow, adapter changes, package metadata, publishing changes, fork links, or generated
distfiles.