Skip to content

Emit script message event when module compilation fails #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksuprynowicz wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

Emit script message event when module compilation fails #2280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad20a7c
Emit script message event when module compilation fails
ksuprynowicz May 19, 2026
23506b7
Always emit critical error to log when script compilation fails.
JulianGro Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions libraries/script-engine/src/v8/ScriptEngineV8.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,13 @@ ScriptValue ScriptEngineV8::evaluateInClosure(const ScriptValue& _closure,
//const V8ScriptValue& closure = unwrappedClosure->toV8Value();
auto compileResult = unwrappedProgram->checkSyntax();
if (compileResult->state() != ScriptSyntaxCheckResult::Valid) {
qCCritical(scriptengine_v8) << "Can't compile script for evaluating in closure. Error message: " << compileResult->errorMessage()
<< " line: " << compileResult->errorLineNumber() << " column: " << compileResult->errorColumnNumber();
QString errorMessage(QString("Can't compile script for evaluating in closure. Error message: : \"") + compileResult->errorMessage() + QString("\" ")
+ QString(" line: ") + QString::number(compileResult->errorLineNumber()) + " column: " + QString::number(compileResult->errorColumnNumber()));
if (_manager) {
_manager->scriptErrorMessage(errorMessage, _program->fileName(),
compileResult->errorLineNumber());
}
Comment thread
JulianGro marked this conversation as resolved.
qCCritical(scriptengine_v8) << errorMessage << _program->fileName() << ":" << compileResult->errorLineNumber();
popContext();
return nullValue();
}
Expand Down
Loading