Skip to content

Emit script message event when module compilation fails - #2280

Open
ksuprynowicz wants to merge 2 commits into
masterfrom
fix/module_compilation_message
Open

Emit script message event when module compilation fails#2280
ksuprynowicz wants to merge 2 commits into
masterfrom
fix/module_compilation_message

Conversation

@ksuprynowicz

Copy link
Copy Markdown
Contributor

Fixes #2274

image

@zedwick zedwick added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels May 19, 2026
@zedwick

zedwick commented May 19, 2026

Copy link
Copy Markdown
Collaborator

What happened to the line and column number?

The log line was:

Can't compile script for evaluating in closure. Error message: "SyntaxError: Unexpected token ')'" line: 5 column: 32

and now I see from your screenshot it is:

Can't compile script for evaluating in closure. Error message: "SyntaxError: Unexpected token ')'"

Missing the following from the end of the message:

line: 5 column: 32

@ksuprynowicz
ksuprynowicz force-pushed the fix/module_compilation_message branch from 3a57409 to d794641 Compare May 19, 2026 15:05
@ksuprynowicz

Copy link
Copy Markdown
Contributor Author
image

Comment thread libraries/script-engine/src/v8/ScriptEngineV8.cpp
@JulianGro
JulianGro force-pushed the fix/module_compilation_message branch from d794641 to 23506b7 Compare June 30, 2026 14:36
@JulianGro
JulianGro requested a review from ada-tv June 30, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Can't compile script for evaluating in closure" not shown in Debug Window

4 participants