Skip to content

test(trails): promote semantic wayfinder dogfood smoke#799

Merged
graphite-app[bot] merged 1 commit into
mainfrom
trl-1054-promote-wayfinder-dogfood-into-a-semantic-multi-app
Jun 19, 2026
Merged

test(trails): promote semantic wayfinder dogfood smoke#799
graphite-app[bot] merged 1 commit into
mainfrom
trl-1054-promote-wayfinder-dogfood-into-a-semantic-multi-app

Conversation

@galligan

@galligan galligan commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Context

Wayfinder dogfood was proving that the operator graph existed, but not enough of the new navigation layer semantics. This branch promotes the release smoke into a multi-app semantic fixture that catches graph-fact, relation, invalid grammar, and rejected-compile provenance drift.

Changes

  • Compile demo and operator topo wrappers inside an isolated temp root.
  • Assert demo resources, signals, errors, deps, and impact facts from saved artifacts.
  • Assert invalid Wayfinder grammar fails visibly.
  • Assert rejected operator compile leaves prior demo artifacts fresh.
  • Preserve existing operator checks for overview, search, contract, outline, deps, impact, diff, and adapter facts.
  • Document the release gate in AGENTS.md and release docs, with a branch-local @ontrails/trails changeset.

Verification

  • bun run wayfinder:dogfood
  • bun run --cwd apps/trails typecheck
  • bun run format:check
  • bun run docs:wrap-check
  • bun test apps/trails/src/tests/survey.test.ts packages/wayfinder/src/tests/loader.test.ts
  • bun run changeset:check
  • bun run check
  • bun run test
  • bun run build
  • bun run publish:check
  • git diff --check
  • gt submit --stack --draft --restack --no-edit --no-interactive --dry-run
  • Graphite pre-push hook passed during submit

Local Review

In-thread local review found no P0-P2 issues. One relevant P3 was fixed before submit: the signal impact assertion now requires the relation edge to originate from entity.updated, proving scoped relation output instead of merely matching any consumer edge.

@linear-code

linear-code Bot commented Jun 19, 2026

Copy link
Copy Markdown

TRL-1054

galligan commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • queue:merge - adds this PR to the back of the merge queue
  • queue:priority - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@galligan galligan marked this pull request as ready for review June 19, 2026 22:26

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@graphite-app

graphite-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merge activity

## Context
Wayfinder dogfood was proving that the operator graph existed, but not enough of the new navigation layer semantics. This branch promotes the release smoke into a multi-app semantic fixture that catches graph-fact, relation, invalid grammar, and rejected-compile provenance drift.

## Changes
- Compile demo and operator topo wrappers inside an isolated temp root.
- Assert demo resources, signals, errors, deps, and impact facts from saved artifacts.
- Assert invalid Wayfinder grammar fails visibly.
- Assert rejected operator compile leaves prior demo artifacts fresh.
- Preserve existing operator checks for overview, search, contract, outline, deps, impact, diff, and adapter facts.
- Document the release gate in AGENTS.md and release docs, with a branch-local @ontrails/trails changeset.

## Verification
- bun run wayfinder:dogfood
- bun run --cwd apps/trails typecheck
- bun run format:check
- bun run docs:wrap-check
- bun test apps/trails/src/__tests__/survey.test.ts packages/wayfinder/src/__tests__/loader.test.ts
- bun run changeset:check
- bun run check
- bun run test
- bun run build
- bun run publish:check
- git diff --check
- gt submit --stack --draft --restack --no-edit --no-interactive --dry-run
- Graphite pre-push hook passed during submit

## Local Review
In-thread local review found no P0-P2 issues. One relevant P3 was fixed before submit: the signal impact assertion now requires the relation edge to originate from entity.updated, proving scoped relation output instead of merely matching any consumer edge.
@graphite-app graphite-app Bot force-pushed the trl-1053-keep-wayfinder-artifact-drift-scoped-to-the-compiled-topo branch from c6fd0d0 to a528239 Compare June 19, 2026 22:27
@graphite-app graphite-app Bot force-pushed the trl-1054-promote-wayfinder-dogfood-into-a-semantic-multi-app branch from bb8cbe8 to de79459 Compare June 19, 2026 22:27
Base automatically changed from trl-1053-keep-wayfinder-artifact-drift-scoped-to-the-compiled-topo to main June 19, 2026 22:31
@graphite-app graphite-app Bot merged commit de79459 into main Jun 19, 2026
9 checks passed
@graphite-app graphite-app Bot deleted the trl-1054-promote-wayfinder-dogfood-into-a-semantic-multi-app branch June 19, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant