fix(wayfinder): keep artifact drift scoped to compiled topo#798
Merged
graphite-app[bot] merged 1 commit intoJun 19, 2026
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Merge activity
|
## Context Wayfinder artifact drift was using one hash interpretation for both artifact integrity and topo-store contract comparison. Forced topo compiles add audit metadata, and blocked breaking compiles could also advance topo-store snapshots before export conflict handling finished. ## Changes - Preflight export artifacts before writing topo-store state so rejected compiles do not create new saved snapshots. - Compare topo.lock/manifest integrity with the full artifact hash, while comparing topo-store exported contract state with force metadata stripped. - Add regressions for blocked compile no-mutation and forced compile fresh Wayfinder artifacts. - Add branch-local changeset for @ontrails/trails and @ontrails/wayfinder. ## Verification - bun test apps/trails/src/__tests__/survey.test.ts packages/wayfinder/src/__tests__/loader.test.ts - bun run wayfinder:dogfood - bun run changeset:check - bun run check - bun run test - bun run build - bun run publish:check - git diff --check - gt submit --stack --draft --restack --no-edit --no-interactive --dry-run - Graphite pre-push hook passed during submit ## Local Review In-thread local review found no P0-P2 issues. Residual non-blocking note: there is not a dedicated Wayfinder unit test for force annotations plus independent topo-store drift, but loader drift tests plus app-level forced and blocked compile regressions cover the intended split.
graphite-app
Bot
force-pushed
the
trl-1053-keep-wayfinder-artifact-drift-scoped-to-the-compiled-topo
branch
from
c6fd0d0 to
a528239
Compare
graphite-app
Bot
deleted the
trl-1053-keep-wayfinder-artifact-drift-scoped-to-the-compiled-topo
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Wayfinder artifact drift was using one hash interpretation for both artifact integrity and topo-store contract comparison. Forced topo compiles add audit metadata, and blocked breaking compiles could also advance topo-store snapshots before export conflict handling finished.
Changes
Verification
Local Review
In-thread local review found no P0-P2 issues. Residual non-blocking note: there is not a dedicated Wayfinder unit test for force annotations plus independent topo-store drift, but loader drift tests plus app-level forced and blocked compile regressions cover the intended split.