fix(lang-v2): preserve qself in InitSpace type paths - #4901
Conversation
Hacktron Security Check - SkippedReason: OSS PR review limit reached for this approved repository and developer. New OSS PRs for this repository will resume at the start of the next cycle.
|
|
@akash-osec is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
ec0f5fe to
e36e20d
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## anchor-next #4901 +/- ##
==============================================
Coverage ? 64.65%
==============================================
Files ? 127
Lines ? 16621
Branches ? 0
==============================================
Hits ? 10746
Misses ? 5875
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e36e20d to
747480a
Compare
747480a to
05a30a3
Compare
Findings (AI # 69 & # 68):
InitSpacemishandles type paths: it drops qself on qualified associated types, and matches built-in sizes by final segment only, socustom::Addressgets32bytes .Fix:
Quote the full TypePath in the fallback, and apply built-in shortcuts only to unqualified single-segment paths so qualified types use
<Type as Space>::INIT_SPACE.