docs: align key export/import tutorial with actual API responses - #62
Open
jrhender wants to merge 1 commit into
Open
docs: align key export/import tutorial with actual API responses#62jrhender wants to merge 1 commit into
jrhender wants to merge 1 commit into
Conversation
jrhender
force-pushed
the
docs/issue-57-wrapup
branch
from
July 3, 2026 13:18
0515ad0 to
12a2251
Compare
jrhender
force-pushed
the
docs/issue-57-wrapup
branch
3 times, most recently
from
July 3, 2026 14:15
2801b11 to
0df6c4e
Compare
- The DID document's verification method exposes publicKeyBase58 (which is the keyId), not a publicKeyJwk with kid - the tutorial predated the Credo migration - The key export response is a publicKey/privateKey pair (KeyPairDto), not a publicKeyThumbprint object - Sample keyIds are now the real base58 values for the sample key material - Fix the broken tutorial link in the app README Part of #57 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
jrhender
force-pushed
the
docs/issue-57-wrapup
branch
from
July 3, 2026 14:28
8e9c392 to
0c4db81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last of five stacked PRs for #57 (stacked on #61).
publicKeyBase58(which is the keyId), not apublicKeyJwkwithkid— the tutorial's samples predated the Credo migrationpublicKey/privateKeypair (KeyPairDto), not apublicKeyThumbprintobjectPart of #57
🤖 Generated with Claude Code