chore: ESLint 10 flat config and Prettier 3 - #60
Open
jrhender wants to merge 2 commits into
Open
Conversation
This was referenced Jul 3, 2026
jrhender
force-pushed
the
chore/ts5-nestjs11-jest30
branch
from
July 3, 2026 13:18
a7d0da9 to
5d25207
Compare
jrhender
force-pushed
the
chore/eslint9-prettier3
branch
from
July 3, 2026 13:18
3b567c3 to
e8fcf8a
Compare
- Replace the four legacy .eslintrc.js files (which extended the unmaintained @energyweb/eslint-config) with a single root eslint.config.mjs flat config: @eslint/js recommended + typescript-eslint v8 recommended + eslint-config-prettier + eslint-plugin-no-only-tests, node/jest globals, projectService for type-aware rules. Linting is centralized: 'pnpm run lint' at the root lints the whole repo (per-package lint scripts removed). - Rule parity kept: @typescript-eslint/no-floating-promises stays an error; no-explicit-any stays a warning (v8 recommended escalated it to an error - existing usages are unchanged and can be typed later). - Fix the real findings the new setup surfaced: unused imports/params and a dead test helper; the OpenAPI script's top-level promise is now explicitly void. - Prettier 2 -> 3 with settings inlined from @energyweb/prettier-config (singleQuote, proseWrap: never) plus the existing repo overrides; trailingComma: 'none' is now explicit since Prettier 3 changed the default to 'all'. pretty-quick 4 for the pre-commit hook. - .prettierignore rewritten for the post-Rush layout. The code reformat from Prettier 3 lands in the next commit to keep this one reviewable. Part of #57 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
Mechanical output of 'prettier --write .' with the settings carried over from Prettier 2 - no functional changes. Part of #57 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
jrhender
force-pushed
the
chore/eslint9-prettier3
branch
from
July 3, 2026 13:39
e8fcf8a to
fe6237b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third of five stacked PRs for #57 (stacked on #59).
.eslintrc.jsfiles (extending the unmaintained@energyweb/eslint-config, last published 2024) with a single rooteslint.config.mjsflat config:@eslint/jsrecommended + typescript-eslint v8 recommended +eslint-config-prettier+eslint-plugin-no-only-tests, node/jest globals,projectServicefor type-aware rules. ESLint 10 directly (typescript-eslint v8 supports it) instead of stopping at v9.pnpm run lintat the root lints the whole repo; per-package lint scripts and lint devDependencies are removed.@typescript-eslint/no-floating-promisesstays an error;no-explicit-anystays a warning (v8 recommended escalated it — the ~20 existing usages are unchanged and can be typed later).@energyweb/prettier-configsettings inlined (singleQuote,proseWrap: never) plus the existing overrides;trailingComma: 'none'is now explicit (Prettier 3 default changed toall).pretty-quick4 for the pre-commit hook;.prettierignorerewritten for the post-Rush layout.Verification
pnpm run lint: 0 errors (21 deliberateanywarnings); build and tests pass after the reformatPart of #57
🤖 Generated with Claude Code