Don't enforce 6 DOFs for WAVGM reference nodes when no rotations - #47
Merged
Conversation
Add method fill() for the tensor classes.
where the inertia calculation is optional
kmokstad
force-pushed
the
solvers-49
branch
3 times, most recently
from
March 21, 2026 07:16
9556f5f to
5c2e050
Compare
Convert function documentation to doxygen syntax. Move static functions into anonymous namespace.
on the WAVGM reference nodes if it couples translations only. Reduce scope of some temporaries using new if-syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes openfedem/fedem-solvers#49. The problem was that the reference nodes of the generated WAVGM elements always were assigned 6 nodal DOFs. But when when the model consists of solid elements only there are not rotational DOFs to couple. The solution is therefore to enforce 3 DOFs only on the reference nodes in this case.