-
Notifications
You must be signed in to change notification settings - Fork 14.3k
code-mode: move to hosted mode by default #31500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
51a7db4
ad91ea2
6795df8
dc96c1b
9a65f76
84a9616
42bfd0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -857,8 +857,8 @@ pub const FEATURES: &[FeatureSpec] = &[ | |
| FeatureSpec { | ||
| id: Feature::CodeModeHost, | ||
| key: "code_mode_host", | ||
| stage: Stage::UnderDevelopment, | ||
| default_enabled: false, | ||
| stage: Stage::Stable, | ||
| default_enabled: true, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With AGENTS.md reference: AGENTS.md:L102-L110 Useful? React with 👍 / 👎. |
||
| }, | ||
| FeatureSpec { | ||
| id: Feature::CodeModeOnly, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the documented local path
just test -p codex-core, Cargo does not build a binary from the separatecodex-code-mode-hostpackage, so this.ok()path is usuallyNone; becauseThreadManager::newalready selected the process-owned provider from the now-defaultcode_mode_host, code-mode tests then try to spawncodex-code-mode-hostnext to the test executable and report tool errors instead of exercising the runtime. The builder needs to ensure a real host binary is available for scoped Cargo runs, or explicitly disableCodeModeHostbefore constructing the manager when it is not.AGENTS.md reference: AGENTS.md:L64-L68
Useful? React with 👍 / 👎.