code-mode: move to hosted mode by default #31500
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad91ea2053
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| crate_name = "codex_core", | ||
| extra_binaries = [ | ||
| "//codex-rs/bwrap:bwrap", | ||
| "//codex-rs/code-mode-host:code-mode-host", |
There was a problem hiding this comment.
When Bazel wires extra_binaries, it derives the CARGO_BIN_EXE_* variable from the label name; this label is the library target code-mode-host, while the test helper looks up cargo_bin("codex-code-mode-host"). In Bazel core tests the new hosted default therefore will not receive a CARGO_BIN_EXE_codex-code-mode-host runfile path, so code-mode tests fall back to a non-existent sibling of the test binary and fail to spawn the host; point this at //codex-rs/code-mode-host:codex-code-mode-host instead.
AGENTS.md reference: AGENTS.md:L216-L220
Useful? React with 👍 / 👎.
| let code_mode_host_program = self | ||
| .code_mode_host_program | ||
| .take() | ||
| .or_else(|| codex_utils_cargo_bin::cargo_bin("codex-code-mode-host").ok()); |
There was a problem hiding this comment.
Under the documented local path just test -p codex-core, Cargo does not build a binary from the separate codex-code-mode-host package, so this .ok() path is usually None; because ThreadManager::new already selected the process-owned provider from the now-default code_mode_host, code-mode tests then try to spawn codex-code-mode-host next to the test executable and report tool errors instead of exercising the runtime. The builder needs to ensure a real host binary is available for scoped Cargo runs, or explicitly disable CodeModeHost before constructing the manager when it is not.
AGENTS.md reference: AGENTS.md:L64-L68
Useful? React with 👍 / 👎.
| stage: Stage::UnderDevelopment, | ||
| default_enabled: false, | ||
| stage: Stage::Stable, | ||
| default_enabled: true, |
There was a problem hiding this comment.
With code_mode_host now defaulting on, a long-lived app-server/TUI process constructs ThreadManager once from the startup config, but each thread/start later reloads and passes its own config overrides to start_thread_with_options; if that per-thread config sets features.code_mode_host=false while using code mode, the session still receives the already-selected process-owned provider and cannot opt back into the in-process runtime. This makes the advertised opt-out ineffective for app-server config overrides unless the provider choice is moved to thread/session creation or rebuilt from the thread config.
AGENTS.md reference: AGENTS.md:L102-L110
Useful? React with 👍 / 👎.
3 participants
Summary