[codex] Implement managed Bedrock login#31326
Draft
celia-oai wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 7, 2026
e8a19f9 to
35ebf5d
Compare
4e95e46 to
fc7cbe0
Compare
fc7cbe0 to
fa240d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App-server clients need a supported way to onboard users with Codex-managed Amazon Bedrock API keys. Bedrock API-key auth is already a primary
CodexAuthmode, so login should reuse the existing auth persistence and reload lifecycle instead of maintaining a separate provider-scoped cache.What changed
login_with_bedrock_api_key, writemodel_provider = "amazon-bedrock", and reload the sharedAuthManagerthrough its generic path.Impact
Managed Bedrock login replaces the current stored Codex login and updates the in-memory auth snapshot. Existing loaded sessions keep their current provider selection, so clients should restart the app-server before sending more model requests.
The auth and config writes remain non-transactional: if the config write fails after credential persistence, durable Bedrock auth can remain for a later retry or explicit cleanup.
Validation
just test -p codex-app-server -E 'test(/suite::v2::account/)'— 40 passedcodex-app-server-protocol,codex-login, andcodex-model-providerpassed in the combined runjust fix -p codex-app-server -p codex-app-server-protocol -p codex-model-providerStack
maincodex/managed-bedrock-apicodex/managed-bedrock-login-v2