[codex] Implement managed Bedrock logout#31325
Draft
celia-oai wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 7, 2026
4e95e46 to
fc7cbe0
Compare
c0be3ad to
c9d1ab6
Compare
fc7cbe0 to
fa240d8
Compare
c9d1ab6 to
1573973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Managed Bedrock API keys are primary
CodexAuthvalues and can use the existing generic logout path. AWS-managed Bedrock credentials are different: they live outside Codex, and logging out while that provider is active must not delete an unrelated stored OpenAI or ChatGPT login.Logout also needs to remove the user-level Bedrock provider default without overwriting a concurrent config change.
What changed
CodexAuth::BedrockApiKeyvalue.AuthManager::logout_with_revokepath for managed Bedrock auth.model_provideronly when it is still"amazon-bedrock", using the config-layer version as a compare-and-set guard.Impact
Logging out of Codex-managed Bedrock removes the primary Bedrock credential and safely clears the persisted Bedrock default. AWS SDK-chain credentials remain untouched.
Validation
just test -p codex-app-server -E 'test(/suite::v2::account/)'— 40 passedjust fix -p codex-app-server -p codex-app-server-protocol -p codex-model-providerStack
maincodex/managed-bedrock-apicodex/managed-bedrock-login-v2