Repository navigation
Agent window demo in the challenge schema - #114
Merged
Merged
Conversation
Contributor
|
🔍 Preview: https://website-5x2mhgyh3-ocobo-22231b32.vercel.app Built from website |
Each element type now has a missing-field and an unknown-key test, and the opening has missing kind and text tests. The KPI count and KPI unknown-key tests use their own element instead of the fixture order. A comment explains why the time is not trimmed.
wab
force-pushed
the
claude/challenge-ai-demo-fbf6f8
branch
from
October 22, 2026 13:24
da3bc88 to
f496783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Optional
aiBridge.demo(agent window) inscripts/schemas/challenge.schema.js, per spec #91, section "aiBridge.demo".channel≤ 28,agent≤ 24,time24-hourHH:MM,opening{kind: question | statement, text ≤ 70},footer≤ 60, optionalnote≤ 90.elements: 1 to 4, discriminated ontype:kpis:items, exactly 3 of{value ≤ 10, label ≤ 16}figure:{value ≤ 12, caption ≤ 48}progress:percentand optionaltarget, integers 0 to 100status:{label ≤ 24, value ≤ 32, state: ok | alert}buttons:labels, 1 to 2, each ≤ 2014:32is read by YAML as the base 60 number 872. The error then says to quote the time.Fixtures
The five mockup windows (ocobo-revops/prototype,
enjeux-*.html) are in their golden fixtures, text verbatim. Revenue AI keeps none and still passes. Each window has four elements, and a test asserts it.Tests (seam 1)
scripts/__tests__/challenge.schema.test.jscovers:type, a missingtypeand a fifth elementopening.kindvaluesReview notes
opening.leadfield is out of scope here.notestays optional (assumption A3, fictional accounts). No mockup carries one yet.timeand elementtypesequence between languages belongs to French and English consistency of challenge files #99.Closes #96