Repository navigation
J3: agent window demo and partner block in the challenge schema - #291
Merged
Merged
Conversation
Mirror posts#113 (partner block, posts#97) and posts#114 (agent window, posts#96) in app/modules/challenge-schema.ts: same names, caps, counts and messages. Recopy the posts golden fixtures, which now carry both blocks, and extend the schema tests. Refs #230
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
What changes
app/modules/challenge-schema.tsgainsaiBridge.demo(optional) andpartner(optional). Both mirror the merged posts schema (Agent window demo in the challenge schema posts#114 for the agent window, Partner block in the challenge schema posts#113 for the partner block): same field names, caps, counts, enums and error messages.app/test/fixtures/content/challenges/fr/is recopied from the posts golden fixtures at posts mainb34a449. Five fixtures now carry an agent window, and Sales Compensation carries the partner block.app/modules/challenge-schema.test.tscovers the acceptance criteria: a fifth element fails, an overlong text fails (frame, every element type, partner), the partner block fails with 1 or 3 metrics or withoutsource, and every posts fixture validates. The other posts cases are ported too (element types, time format, missing fields, unknown keys).Differences between the issue text and the posts schema
The website follows the posts schema, not the issue wording.
opening: { kind: question | statement, text }, not aquestionfield. Three of the five mockups open on a statement.noteshown under the window.{ before, after, label }. The issue only says "two metrics".buttonstakes one or two labels.progresstakespercentand an optionaltarget, integers from 0 to 100.timeis a quotedHH:MMstring.Parsing difference to know
The website parses YAML with js-yaml 4 and the core schema, so an unquoted
time: 14:32stays the string"14:32"and passes. The posts repo (js-yaml 3) reads it as 872 and rejects it. The website still accepts every file posts accepts. A test documents both behaviours.Release order
Deploy this PR before merging posts content that uses
partneroraiBridge.demo: the current website schema rejects both as unknown keys, and a list fetch fails on the first rejected file.Not in scope
partner.toolnames a Tool file. The website does no cross-reference check.docs/api/data-models.mddoes not describe the challenge schema, so it is unchanged.Checks
pnpm check,pnpm typecheck,pnpm test:run(829 tests) green. A code review of the diff confirmed exact parity with the posts schema; its findings (two missing posts cases, a misplaced comment, an unused type export, the YAML parsing test) are fixed.