Repository navigation
Partner block in the challenge schema - #113
Merged
Merged
Conversation
Adds partner (tool, sentence, two before/after metrics, required source) to the challenge schema with its caps, checks partner.tool against Tool slugs in validateRepository, and gives the Sales Compensation fixture the Qobra block from the mockup. Closes #97
Contributor
|
🔍 Preview: https://website-3j1nq9p6k-ocobo-22231b32.vercel.app Built from website |
Applies the PR #113 review: the partner.tool cross-reference no longer trims, like team tools and featuredTool. The fixture edit in the cross-reference tests now throws when it does not apply, the cap tests cover the second metric, and CLAUDE.md lists partner.tool among the strict cross-refs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
What
scripts/schemas/challenge.schema.js: optionalpartnerblock, strict, placed afterworkstreamsas in the mockup.toolis a Tool slug,sentence≤ 140,metricsexactly 2 of{before ≤ 12, after ≤ 12, label ≤ 90},sourcerequired ≤ 90. No field names Qobra.scripts/validate-repository.js:partner.toolmust be an existing Tool slug. The error names the slug, at pathpartner.tool. Like teamtoolsandfeaturedTool, the raw value is checked, so a padded slug is rejected.scripts/__tests__/fixtures/challenges/sales-compensation.md: gainspartner.tool: qobrawith the sentence, metrics and source ofenjeux-remuneration-variable.html(ocobo-revops/prototype,main).Tests
scripts/__tests__/challenge.schema.test.js): 1 and 3 metrics fail, each missing field fails (sourceincluded), each cap (both metrics) accepts its limit and fails one past it, blanktooland unknown keys fail, a challenge withoutpartnerpasses, any challenge key may carry it.scripts/__tests__/validate-repository.test.js):partner.tool: ghost-toolfails with"ghost-tool" does not match any tool slug; a padded" qobra "fails too; the Sales Compensation fixture withtools/qobra.mdpasses. The fixture edit throws when it does not apply.CLAUDE.md:partner.tooladded to "Cross-refs are strict".pnpm test399 passed,pnpm validategreen.Choices to review
[Bloc à valider avec Qobra]after the source is left out ofsource: it is a mockup reminder, not page copy.(source : Qobra)suffix verbatim, althoughsourcealready attributes the figures. Drop it when Qobra validates the block (assumption A2) if the page should not repeat the attribution.after: "1"is quoted in YAML: an unquoted1is a number and fails the string schema.Not in this PR
partner.toolmay point to a Tool withouticonUrl(optional intool.schema.js), so the block could render without its logo. RequiringiconUrlfor a partner Tool is a spec decision, not taken here.method.toolscross-reference: Challenge cross-references and uniqueness #98.partner.tool: the repository-wide fr/en rule from Spec: challenge content type and Team member expert fields #91.partner. TheaiBridge.demoPR (Agent window demo in the challenge schema #96) edits the same schema, test and fixture files, so the second to merge rebases.