slides: the slide list steps aside once you have picked a slide - #272
Open
iamgeo92 wants to merge 1 commit into
Open
slides: the slide list steps aside once you have picked a slide#272iamgeo92 wants to merge 1 commit into
iamgeo92 wants to merge 1 commit into
Conversation
iamgeo92
force-pushed
the
phone-drawer-close-on-pick
branch
2 times, most recently
from
August 10, 2026 02:28
6b8c07d to
fac7317
Compare
Below 700px the side panels are not columns — styles.css makes them overlay drawers laid across the canvas, because a 188px column beside a 402px screen leaves the thing being edited as the smallest thing on it. Tapping a thumbnail navigated correctly and then left the drawer covering the slide it had just navigated to, so every slide change cost a second trip to the toggle in the topbar to actually see the result. Closing is scoped to the drawer width and to the thumbnail itself: on a wide screen the list is a real column and stays put, and the Duplicate and Delete buttons on a thumbnail already stop propagation, so editing the list never dismisses it.
iamgeo92
force-pushed
the
phone-drawer-close-on-pick
branch
from
August 10, 2026 23:51
fac7317 to
47b6819
Compare
Author
|
@nyblnet — review whenever suits you. Small one: below 700px the slide list is an overlay drawer (which is the right call — the CSS comment explains why), but tapping a thumbnail left it sitting on top of the slide it had just navigated to, so every slide change cost a second trip to ☰. Scoped two ways so nothing changes elsewhere: only while the panel is a drawer, and only from the thumbnail itself — the per-thumb Duplicate/Delete already stop propagation, so editing the list never dismisses it. One file, +25/−1. #273 is stacked on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Below 700px the side panels are not columns —
styles.cssdeliberately turnsthem into overlay drawers laid across the canvas:
That is the right call. But the thumbnail click handler was written for the
column layout:
So on a phone, tapping a slide navigated correctly and then left the drawer
sitting on top of the slide it had just navigated to. Every slide change
cost a second trip to the ☰ toggle in the topbar just to see what you picked.
The fix
The drawer steps aside when you pick from it.
Closing is scoped two ways, so nothing changes where the panel is not a drawer:
≤700px, the samethreshold the CSS and
applyPhoneChromealready use). On a wide screen thelist is a real column beside the canvas and stays exactly where it is.
Delete buttons already
stopPropagation, so editing the list neverdismisses it. Those are edits to the list, not a choice of slide.
Before / after
Same gestures both sides: open ☰, tap slide 3.
In the "before" clip you can see the extra step the old behaviour forced: find
☰ again, press it, then look at your slide.
How this was verified
Dev server, Chrome DevTools iPhone emulation (390×664, DPR 3,
hasTouch) withreal touch dispatch, plus a 1280×800 mouse context for the desktop cases:
Gates:
No new user-facing strings, so no i18n catalog changes. No format or kernel
change; nothing under
sync/.Scope note: this PR deliberately covers only picking a slide. Dismissing a
drawer by tapping the canvas outside it is a separate gap and a separate PR, so
the two do not tangle in review.
Caveat: verified under Chromium's iPhone emulation rather than on physical
iOS hardware. This change is layout-threshold and event-target logic with no
WebKit-specific behaviour in it, so the risk of an emulation-only result is low.
Changelog entry — not in the diff, on purpose
CHANGELOG.mdis this repo's named conflict magnet (docs/PARALLEL-WORK.md§3). With several of these open at once, and[Unreleased]being emptied every time a release is cut, a changelog hunk made every one of them conflict on that file and nothing else — twice over. They carry noCHANGELOG.mdchange so they stay mergeable; here is the entry to drop in at release time, or I'll add it back in whatever form you prefer.