Fix some data races - #14
Merged
Merged
Conversation
To guard against this method reading data while the imu thread is writing to buffer.
Can happen for sensors sharing same hw clock as imu
Contributor
|
Thanks for the PR. I'd fixed this locally but hadn't pushed anywhere. Will check the differences between that and this and report back. |
Contributor
|
Changes look good, thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was because some random baro measurements would have exact same nanosecond stamp as a given imu measurement because they shard hw clock.
This should now be better handled in dd1672f
Removed the two-step mutex acqusition in
setPropagationBaseStateto reduce complexity. This will be catched up by next imu callback anyway?