Skip to content

acl: add comment field to EACL records #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cthulhu-rider merged 1 commit into from
Jul 21, 2026
Merged

acl: add comment field to EACL records #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions acl/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ message EACLRecord {
}
// List of target subjects to apply ACL rule to
repeated Target targets = 4 [json_name = "targets"];

// Optional auxiliary data associated with the rule. The comment does not
// affect permission evaluation and must be valid UTF-8 without zero bytes.

@cthulhu-rider cthulhu-rider Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd also limit its len. Start with a conservative value like 1KiB

@roman-khimov roman-khimov Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's somewhat more complicated, related to limits for targets and keys. Looks like we don't have any in API now. At the same time we have a hard overall limit for EACL (#398).

string comment = 5 [json_name = "comment"];
}

// Extended ACL rules table. A list of ACL rules defined additionally to Basic
Expand Down
1 change: 1 addition & 0 deletions proto-docs/acl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ Describes a single eACL rule.
| action | [Action](#neo.fs.v2.acl.Action) | | Rule execution result. Either allows or denies access if filters match. |
| filters | [EACLRecord.Filter](#neo.fs.v2.acl.EACLRecord.Filter) | repeated | List of filters to match and see if rule is applicable |
| targets | [EACLRecord.Target](#neo.fs.v2.acl.EACLRecord.Target) | repeated | List of target subjects to apply ACL rule to |
| comment | [string](#string) | | Optional auxiliary data associated with the rule. The comment does not affect permission evaluation and must be valid UTF-8 without zero bytes. |


<a name="neo.fs.v2.acl.EACLRecord.Filter"></a>
Expand Down
Loading