acl: add comment field to EACL records#401
Merged
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 20, 2026 13:40
End-rey
force-pushed
the
eacl-comment-field
branch
from
July 21, 2026 08:37
cbf6fdb to
d5cb2f4
Compare
Closes #400. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
| repeated Target targets = 4 [json_name = "targets"]; | ||
|
|
||
| // Optional auxiliary data associated with the rule. The comment does not | ||
| // affect permission evaluation and must be valid UTF-8 without zero bytes. |
Contributor
There was a problem hiding this comment.
i'd also limit its len. Start with a conservative value like 1KiB
Member
There was a problem hiding this comment.
That's somewhat more complicated, related to limits for targets and keys. Looks like we don't have any in API now. At the same time we have a hard overall limit for EACL (#398).
roman-khimov
approved these changes
Jul 21, 2026
cthulhu-rider
approved these changes
Jul 21, 2026
End-rey
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Jul 21, 2026
Add accessors for EACL record comments and preserve them during copying and protobuf serialization. Refs nspcc-dev/neofs-api#401. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
roman-khimov
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400.