konsole: allow defining custom colorschemes with Nix values#564
Merged
magnouvean merged 3 commits intoJul 9, 2026
Conversation
Contributor
|
I like this change. What do you think about a more fine-grained approach like this one? This would yield colour names more descriptive than |
Contributor
Author
|
I'd like to keep the module simple, so we don't need to keep up with any schema changes of the file from Konsole in the future. I can add an example config to the option so users reading the documentation have an idea how to create a custom colorscheme right away. |
Collaborator
|
Yeah I probably agree that this is the right way of doing this. If you could add an example though then it would be great! Otherwise looks fine 👍 |
folliehiyuki
force-pushed
the
ini-konsole-colorscheme
branch
from
75c845d to
fcdd678
Compare
Contributor
Author
|
Example string added for the colorscheme option. |
Collaborator
|
Looks good! |
scarlet-storm
added a commit
to scarlet-storm/plasma-manager
that referenced
this pull request
Jul 11, 2026
Regression from nix-community#564 passing store paths for programs.konsole.customColorSchemes no longer works. builtins.isPath is only true for primitive types and not string interpolated nix store paths (eg. "${pkgs.foo}/bar.colorscheme"). this causes iniFormat.generate to be called for store paths. Instead use lib.types.path.check which uses the same check as lib.types.path (primitive path or strings starting with /)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach allows further override of useful values like
BlurandAchor.