konsole: fix passing store path to customColorSchemes#638
Open
scarlet-storm wants to merge 1 commit into
Open
Conversation
Regression from nix-community#564 passing store paths for programs.konsole.customColorSchemes no longer works. builtins.isPath is only true for primitive types and not string interpolated nix store paths (eg. "${pkgs.foo}/bar.colorscheme"). this causes iniFormat.generate to be called for store paths. Instead use lib.types.path.check which uses the same check as lib.types.path (primitive path or strings starting with /)
scarlet-storm
force-pushed
the
konsole-colorscheme
branch
from
July 11, 2026 07:36
646e347 to
b118e73
Compare
scarlet-storm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #564 passing store paths for
programs.konsole.customColorSchemes no longer works. builtins.isPath is only true for primitive types and not string interpolated nix store paths (eg. "${pkgs.foo}/bar.colorscheme"). this causes iniFormat.generate to be called for store paths. Instead use lib.types.path.check which uses the same check as lib.types.path (primitive path or strings starting with /)