Skip to content

Fix(embedded) : column order, sort, scrolls overlays, refresh, table … - #2868

Merged
enjeck merged 3 commits into
nextcloud:mainfrom
taiebot:Embedded-fix
Aug 30, 2026
Merged

Fix(embedded) : column order, sort, scrolls overlays, refresh, table …#2868
enjeck merged 3 commits into
nextcloud:mainfrom
taiebot:Embedded-fix

Conversation

@taiebot

@taiebot taiebot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🖼️ Screenshots

🏚️ Before 🏡 After
B image
B image

View order
image

Widget order
image

a little gif sorry the first seconds are frozen

tables

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Comment thread src/views/ContentReferenceWidget.vue
Comment thread src/views/ContentReferenceWidget.vue
Comment thread src/views/ContentReferenceWidget.vue
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@enjeck
enjeck force-pushed the Embedded-fix branch 2 times, most recently from 25a87a2 to e25731a Compare August 27, 2026 09:22

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Please fix lint with npm run cs:fix

@enjeck enjeck mentioned this pull request Aug 30, 2026
5 tasks
…height

* Fix: column order for embedded table

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* fix(widget): use fresh store data for rows/columns in ContentReferenceWidget

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* Fix embed col order (#12)

* Fix: column order for embedded table

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* fix(widget): use fresh store data for rows/columns in ContentReferenceWidget

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

---------

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* Embed scroll (#11)

* Adjust height and z-index in ContentReferenceWidget (#7)

Signed-off-by: taiebot <dedreuil@yahoo.fr>

* Fix Change height of tables-content-widget to auto

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

---------

Signed-off-by: taiebot <dedreuil@yahoo.fr>
Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* Fix: enable sorting on ContentReferenceWidget

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* Fix watcher for localViewSetting with debug logging

Added a watcher for localViewSetting to log changes for debugging purposes.

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* Fix Remove debug watcher for localViewSetting

Removed temporary debug watcher for localViewSetting.

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

* Fix again 

Refactor loadColumnsFromBE to improve column sorting logic and add comments for clarity.

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>

---------

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>
Signed-off-by: taiebot <dedreuil@yahoo.fr>
put back the early return

Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck linked an issue Aug 30, 2026 that may be closed by this pull request

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm!

@enjeck
enjeck merged commit e36d365 into nextcloud:main Aug 30, 2026
61 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded tables some column overflow on header

2 participants