fix(relations): Fix relations loading in applications, references, analytics - #2923
Open
Koc wants to merge 3 commits into
Open
fix(relations): Fix relations loading in applications, references, analytics#2923Koc wants to merge 3 commits into
Koc wants to merge 3 commits into
Conversation
Koc
force-pushed
the
bugfix/fix-relations-loading-in-applications
branch
from
August 28, 2026 00:18
632226a to
9250ea8
Compare
Koc
changed the title
Koc
force-pushed
the
bugfix/fix-relations-loading-in-applications
branch
2 times, most recently
from
August 28, 2026 08:52
98ef0e8 to
a59929b
Compare
Koc
marked this pull request as ready for review
August 28, 2026 23:42
enjeck
reviewed
Aug 29, 2026
Comment on lines
60
to
68
| relationOptions() { | ||
| const dataStore = useDataStore() | ||
| const activeElement = this.activeView || this.activeTable | ||
| if (activeElement) { | ||
| const columnRelations = dataStore.getRelations(this.column.id) | ||
| return Object.values(columnRelations) | ||
| } | ||
| return [] | ||
| }, |
Contributor
There was a problem hiding this comment.
This leaves the write path with the same bug this PR removes from RelationColumn.getLabel() ?
Comment on lines
52
to
58
| loading() { | ||
| const dataStore = useDataStore() | ||
| const activeElement = this.activeView || this.activeTable | ||
| if (activeElement) { | ||
| return dataStore.getRelationsLoading(!!this.activeView, activeElement.id) | ||
| } | ||
| return false |
Contributor
There was a problem hiding this comment.
In an application context , neither activeTable nor activeView is ever set, so activeElement is undefined. In a context this always returns false, so the picker never shows a loading state?
Comment on lines
78
to
87
| async mounted() { | ||
| const activeElement = this.activeView || this.activeTable | ||
| if (activeElement) { | ||
| await this.loadRelationsFromBE({ | ||
| tableId: this.activeTable?.id, | ||
| viewId: this.activeView?.id, | ||
| force: true, | ||
| }) | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Because activeElement is null in a context, this mounted load is skipped there. Should we load from the column's tableId
Contributor
There was a problem hiding this comment.
onSharePermissions can be null, so let's optionally chain these? And others below
Koc
force-pushed
the
bugfix/fix-relations-loading-in-applications
branch
from
August 30, 2026 12:15
0d9053e to
9b6b0ca
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
bugfix/fix-relations-loading-in-applications
branch
from
August 30, 2026 13:21
a970578 to
cfe987b
Compare
Contributor
Author
Koc
changed the title
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
bugfix/fix-relations-loading-in-applications
branch
from
August 30, 2026 16:05
eee9360 to
b9cecdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 5 errors related to relation column type. Closes #2858, Closes #2915
🖼️ Screenshots
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)