Skip to content

fix(CallView): solve undefined array watcher error #19090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DorraJaouad merged 1 commit into from
Aug 25, 2026
Merged

fix(CallView): solve undefined array watcher error #19090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/CallView/CallView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,10 @@ export default {
// A single active speaker keeps the main area for itself, rather
// than being the only tile of the speakers grid
?? (this.showSpeakers ? this.promotedSpeakerModels[0] : undefined)
?? this.callParticipantModels.find((callParticipantModel) => this.sharedDatas[callParticipantModel.attributes.peerId].promoted)
// The shared data of a model is set from a watcher, so it may not
// be there yet when this is evaluated right after the model was
// added
?? this.callParticipantModels.find((callParticipantModel) => this.sharedDatas[callParticipantModel.attributes.peerId]?.promoted)
Comment thread
DorraJaouad marked this conversation as resolved.
?? this.callParticipantModels[0]
},

Expand Down Expand Up @@ -596,7 +599,7 @@ export default {
promotedAreaSessionIds(sessionIds, previousSessionIds) {
// Runs before the grids are re-rendered, while the tiles are still
// where they are about to move from
animateTilePromotion(sessionIds, previousSessionIds)
animateTilePromotion(sessionIds, previousSessionIds ?? [])
},

speakers: {
Expand Down Expand Up @@ -987,7 +990,7 @@ export default {
// bad specially with a low number of participants.
if (this.isGrid) {
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.MEDIUM, SIMULCAST.HIGH)
} else if (this.sharedDatas[callParticipantModel.attributes.peerId].promoted
} else if (this.sharedDatas[callParticipantModel.attributes.peerId]?.promoted
|| this.selectedVideoPeerId === callParticipantModel.attributes.peerId
|| this.promotedSpeakerPeerIds.has(callParticipantModel.attributes.peerId)) {
callParticipantModel.setSimulcastVideoQuality(SIMULCAST.HIGH, SIMULCAST.HIGH)
Expand Down
Loading