Skip to content

fix(CallView): solve undefined array watcher error - #19090

Merged
DorraJaouad merged 1 commit into
mainfrom
fix/noid/callview-error
Aug 25, 2026
Merged

fix(CallView): solve undefined array watcher error#19090
DorraJaouad merged 1 commit into
mainfrom
fix/noid/callview-error

Conversation

@DorraJaouad

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Based in debugging:
    promotedAreaSessionIds -> promotedParticipantModel -> this.sharedDatas[peerId].promoted with sharedDatas still {} while callParticipantModels already has entries -> Cannot read properties of undefined (reading 'promoted').

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image Screenshot after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
DorraJaouad requested a review from Antreesy August 25, 2026 11:03
@DorraJaouad DorraJaouad self-assigned this Aug 25, 2026
@DorraJaouad DorraJaouad added this to the ⛅ Next Beta/RC (35) milestone Aug 25, 2026

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Comment thread src/components/CallView/CallView.vue
…els so accomodate watchers with this order

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
DorraJaouad force-pushed the fix/noid/callview-error branch from 19d0de1 to 3bb1390 Compare August 25, 2026 11:33
@DorraJaouad
DorraJaouad enabled auto-merge August 25, 2026 11:33
@DorraJaouad
DorraJaouad merged commit 2c68f22 into main Aug 25, 2026
53 checks passed
@DorraJaouad
DorraJaouad deleted the fix/noid/callview-error branch August 25, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants