fix(upload): construct referenceId for grouped uploads - #19040
Merged
Conversation
Antreesy
added
enhancement
feature: frontend 🖌️
Antreesy
changed the title
ShGKme
approved these changes
Aug 20, 2026
- construct referenceId in the following format:
- /[a-f0-9]{60}-[0-9]{3}/, where:
- /[a-f0-9]{60}/ - uploadId hashed with SHA-256 algorithm
- /-/ - mandatory delimiter
- /[0-9]{3}/ - order of file in given upload (natural integers, padded with zeroes)
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/11411/reference-id
branch
from
August 21, 2026 12:53
2b591ba to
bcaddea
Compare
11 tasks
Member
|
Might make sense to document in spreed/lib/ResponseDefinitions.php Lines 234 to 235 in d913950 |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
enabled auto-merge
August 25, 2026 08:47
mahibi
added a commit
to nextcloud/talk-android
that referenced
this pull request
Aug 27, 2026
Files sent from the Upload Preview Screen in one batch now get a cross-client referenceId (sha256(uploadId)-order, matching nextcloud/spreed#19040) and render as a single WhatsApp-style grouped bubble instead of one message per file - an adaptive media grid for images/videos plus a stacked list for other file types. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
/[a-f0-9]{60}-[0-9]{3}/, where:/[a-f0-9]{60}/- uploadId hashed with SHA-256 algorithm/-/- mandatory delimiter/[0-9]{3}/- order of file in given upload (natural integers, padded with zeroes)AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
With applied grouping rules (two separate upload initiated within a minute):
🏁 Checklist