fix(upload): combine temporary file messages - #19046
Merged
Merged
Conversation
Antreesy
added
bug
design
feature: frontend 🖌️
Antreesy
force-pushed
the
fix/noid/file-upload-progress
branch
from
August 25, 2026 12:36
683c5ac to
7d2a348
Compare
DorraJaouad
reviewed
Aug 26, 2026
DorraJaouad
left a comment
DorraJaouad
left a comment
Contributor
There was a problem hiding this comment.
I am not sure about the on-top-of-image-position as it may be inaccessible
| :class="{ 'file-preview__progress--pending': !uploadProgress }" | ||
| type="circular" | ||
| :value="uploadProgress" /> | ||
| :value="uploadProgress || 30" /> |
Contributor
There was a problem hiding this comment.
The spinner should reflect the error or be removed
Contributor
There was a problem hiding this comment.
Also it is redundant in loading ?
Contributor
Author
There was a problem hiding this comment.
Position above image is aligned with design
Hidden on failed upload - fixed in last commit
Double spinners - upload progress, and message loading serves different function, makes more sense when it's multiple file uploaded
- if await for compressImage (~100-200ms), it would produce visual disruption Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- if messages will be combined after they shared, they should look correctly during upload as well Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- move circle in file icon/preview area - render indeterminate state as spinner Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/file-upload-progress
branch
from
August 26, 2026 12:18
7d2a348 to
ea98e48
Compare
Contributor
Author
|
/backport to stable35 |
DorraJaouad
approved these changes
Aug 26, 2026
Contributor
Author
|
Green before, green locally with last commit changes, force-merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏚️ Before
Recording.2026-08-21.145908.mp4
🏡 After
Recording.2026-08-21.150050.mp4
🏁 Checklist