Skip to content

refactor(MessageBody): extract FilePreview rendering to new component - #19020

Merged
Antreesy merged 2 commits into
mainfrom
fix/noid/file-p2-new-component
Aug 18, 2026
Merged

refactor(MessageBody): extract FilePreview rendering to new component#19020
Antreesy merged 2 commits into
mainfrom
fix/noid/file-p2-new-component

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • render all file shares of a message via FilePreviewsWrapper instead of inline placeholders in NcRichText
  • allow more flexibility in rendering/sorting/modification of combined file messages (client-only)
  • skip NcRichText for files wthout caption

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes noticed

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Stack created with GitHub Stacks CLIGive Feedback 💬

@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Aug 17, 2026
@Antreesy
Antreesy requested a review from DorraJaouad August 17, 2026 16:38
@Antreesy Antreesy self-assigned this Aug 17, 2026
@Antreesy Antreesy added technical debt feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Aug 17, 2026
@Antreesy Antreesy added this to the ⛅ Next Beta/RC (35) milestone Aug 17, 2026
Comment thread src/components/MessagesList/MessagesGroup/Message/MessageItem.vue Outdated
Base automatically changed from fix/noid/file-p1-audio-player to main August 17, 2026 19:42
@Antreesy
Antreesy force-pushed the fix/noid/file-p2-new-component branch 2 times, most recently from c86df43 to 49a388e Compare August 18, 2026 12:43
@Antreesy
Antreesy requested a review from DorraJaouad August 18, 2026 12:43
- render all file shares of a message via FilePreviewsWrapper instead of inline placeholders in NcRichText
- allow more flexibility in rendering/sorting/modification of combined file messages (client-only)
- skip NcRichText for files wthout caption

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- contact card shares use the same 'file' key as regular files, but rendered with ContactCard.vue
- they are not excluded from richParameters and rendered via NcRichText

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/file-p2-new-component branch from 49a388e to e5e1aef Compare August 18, 2026 15:53
@Antreesy
Antreesy enabled auto-merge August 18, 2026 16:22
@Antreesy
Antreesy merged commit 48deef6 into main Aug 18, 2026
53 checks passed
@Antreesy
Antreesy deleted the fix/noid/file-p2-new-component branch August 18, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants