design(chat): rearrange file previews in combined message - #19005
Open
Antreesy wants to merge 3 commits into
Open
design(chat): rearrange file previews in combined message#19005Antreesy wants to merge 3 commits into
Antreesy wants to merge 3 commits into
Conversation
Antreesy
added
feature: frontend 🖌️
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Antreesy
marked this pull request as draft
August 17, 2026 16:41
This comment was marked as resolved.
This comment was marked as resolved.
Antreesy
force-pushed
the
fix/18989/multiple-files
branch
from
August 25, 2026 17:04
7c80ca6 to
13ff9f0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
- make a two-line layout (name / extension + size) - increase mime-icon size to 32px Assisted-by: ClaudeCode:claude-sonnet-5
Antreesy
force-pushed
the
fix/18989/multiple-files
branch
from
September 2, 2026 14:26
13ff9f0 to
da786b1
Compare
Antreesy
changed the title
Antreesy
marked this pull request as ready for review
September 2, 2026 14:27
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- allow to navigate left-right in the Viewer within a combined file message Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/18989/multiple-files
branch
from
September 2, 2026 14:44
da786b1 to
8e885ee
Compare
DorraJaouad
reviewed
Sep 3, 2026
| <FilePreview | ||
| v-for="key in otherKeys" | ||
| :key="key" | ||
| rowLayout |
Contributor
There was a problem hiding this comment.
You forgot single messages :/
Contributor
Author
There was a problem hiding this comment.
Looks fine? Or you want large PDF mimeicon?)
| let list = [this.file] | ||
| let loadMore = undefined | ||
|
|
||
| if (this.itemType === SHARED_ITEM.TYPES.MEDIA && this.isSharedItems) { |
Contributor
There was a problem hiding this comment.
This would prevent across messages media navigation. You can see in one pic message you cannot navigate to other media
Contributor
Author
There was a problem hiding this comment.
that was reported as confusing internally (esp. the direction left-right for new-old), and would be the goal. Other media still available from shared items tab (and they have to be loaded anyway)
| height: calc(var(--preview-size) + var(--preview-name-height)); | ||
| min-width: 0; | ||
| max-width: var(--preview-size); | ||
| aspect-ratio: 1; |
Contributor
There was a problem hiding this comment.
failed image previews in combined tiles. The tile now uses aspect-ratio:1; height:auto; line-height:0 and dropped the --preview-name-height reservation, so when a preview fails and shouldShowFileDetail flips true, the name renders inside a fixed square with line-height:0 and overflows/collapses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 TODO
🏁 Checklist