Skip to content

fix: sync session storage with signaling connection - #17675

Merged
Antreesy merged 2 commits into
mainfrom
fix/noid/session-storage
Apr 13, 2026
Merged

fix: sync session storage with signaling connection#17675
Antreesy merged 2 commits into
mainfrom
fix/noid/session-storage

Conversation

@Antreesy

@Antreesy Antreesy commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Follow-up to feat: add permanent call rooms frontend #17332
  • But should also be the case before, so need a backport
  • Test scenario 1:
    • Join voice room
    • Leave to dashboard
    • Join the same room again
    • See error
  • Test scenario 2:
    • Join voice room
    • Reload the page
    • See error

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy added 2 commits April 10, 2026 09:47
@Antreesy
fix(SessionStorage): drop 'joined_conversation' when switching to ano…
f13ee00 
…ther one

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(SessionStorage): drop 'joined_conversation' on page unload
3c318a9 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Apr 10, 2026
@Antreesy
Antreesy requested review from DorraJaouad and ShGKme April 10, 2026 08:07
@Antreesy Antreesy self-assigned this Apr 10, 2026
@Antreesy Antreesy added bug feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Apr 10, 2026
@Antreesy
Antreesy merged commit 8e8f876 into main Apr 13, 2026
53 checks passed
@Antreesy
Antreesy deleted the fix/noid/session-storage branch April 13, 2026 12:30
@Antreesy

Antreesy commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@Antreesy

Antreesy commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@backportbot backportbot Bot mentioned this pull request Apr 13, 2026
Merged
@backportbot backportbot Bot mentioned this pull request Apr 13, 2026
Merged
Antreesy added a commit that referenced this pull request Apr 14, 2026
@Antreesy
revert: "fix: sync session storage with signaling connection" #17675
fc010c7
@Antreesy Antreesy mentioned this pull request Apr 15, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes
@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v24.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Antreesy @ShGKme