Skip to content

Commit fc010c7

Browse files
committed
revert: "fix: sync session storage with signaling connection" #17675
1 parent 9da4c7f commit fc010c7

6 files changed

Lines changed: 0 additions & 13 deletions

File tree

src/App.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@ export default {
287287
window.addEventListener('unload', () => {
288288
console.info('Navigating away, leaving conversation')
289289
if (this.token) {
290-
SessionStorage.removeItem('joined_conversation')
291290
// We have to do this synchronously, because in unload and beforeunload
292291
// Promises, async and await are prohibited.
293292
signalingKill()

src/FilesSidebarTabApp.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import { getFileConversation } from './services/filesIntegrationServices.ts'
4646
import {
4747
leaveConversationSync,
4848
} from './services/participantsService.js'
49-
import SessionStorage from './services/SessionStorage.js'
5049
import { useActorStore } from './stores/actor.ts'
5150
import { useTokenStore } from './stores/token.ts'
5251
import { checkBrowser } from './utils/browserCheck.ts'
@@ -183,7 +182,6 @@ export default {
183182
window.addEventListener('unload', () => {
184183
console.info('Navigating away, leaving conversation')
185184
if (this.token) {
186-
SessionStorage.removeItem('joined_conversation')
187185
// We have to do this synchronously, because in unload and beforeunload
188186
// Promises, async and await are prohibited.
189187
signalingKill()

src/PublicShareAuthSidebar.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ import {
4343
leaveConversationSync,
4444
setGuestUserName,
4545
} from './services/participantsService.js'
46-
import SessionStorage from './services/SessionStorage.js'
4746
import { useActorStore } from './stores/actor.ts'
4847
import { useTokenStore } from './stores/token.ts'
4948
import { signalingKill } from './utils/webrtc/index.js'
@@ -116,7 +115,6 @@ export default {
116115
window.addEventListener('unload', () => {
117116
console.info('Navigating away, leaving conversation')
118117
if (this.token) {
119-
SessionStorage.removeItem('joined_conversation')
120118
// We have to do this synchronously, because in unload and beforeunload
121119
// Promises, async and await are prohibited.
122120
signalingKill()

src/PublicShareSidebar.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ import { getPublicShareConversationData } from './services/filesIntegrationServi
5959
import {
6060
leaveConversationSync,
6161
} from './services/participantsService.js'
62-
import SessionStorage from './services/SessionStorage.js'
6362
import { useActorStore } from './stores/actor.ts'
6463
import { useTokenStore } from './stores/token.ts'
6564
import { checkBrowser } from './utils/browserCheck.ts'
@@ -143,7 +142,6 @@ export default {
143142
beforeMount() {
144143
window.addEventListener('unload', () => {
145144
if (this.token) {
146-
SessionStorage.removeItem('joined_conversation')
147145
// We have to do this synchronously, because in unload and beforeunload
148146
// Promises, async and await are prohibited.
149147
signalingKill()

src/RecordingApp.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { onBeforeMount } from 'vue'
88
import { useRoute, useRouter } from 'vue-router'
99
import CallView from './components/CallView/CallView.vue'
1010
import { useGetToken } from './composables/useGetToken.ts'
11-
import SessionStorage from './services/SessionStorage.js'
1211
import { useSoundsStore } from './stores/sounds.js'
1312
import { useTokenStore } from './stores/token.ts'
1413
import { signalingKill } from './utils/webrtc/index.js'
@@ -32,7 +31,6 @@ onBeforeMount(async () => {
3231
window.addEventListener('unload', () => {
3332
console.info('Navigating away, leaving conversation')
3433
if (token.value) {
35-
SessionStorage.removeItem('joined_conversation')
3634
// We have to do this synchronously, because in unload and
3735
// beforeunload Promises, async and await are prohibited.
3836
signalingKill()

src/store/participantsStore.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,10 +1101,6 @@ const actions = {
11011101
* @param {string} data.token - conversation token.
11021102
*/
11031103
async leaveConversation(context, { token }) {
1104-
if (SessionStorage.getItem('joined_conversation') === token) {
1105-
// Drop token from SessionStorage to not consider a room joined anymore
1106-
SessionStorage.removeItem('joined_conversation')
1107-
}
11081104
const actorStore = useActorStore()
11091105
if (context.getters.isInCall(token)) {
11101106
await context.dispatch('leaveCall', {

0 commit comments

Comments
 (0)