feat: add permanent call rooms frontend - #17332
Merged
Merged
Conversation
Antreesy
reviewed
Mar 11, 2026
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
2 times, most recently
from
March 23, 2026 12:30
c7c16bc to
13f01e7
Compare
Antreesy
approved these changes
Mar 23, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Otherwise no objections, clean and simple. Let's wait for design feedback!
Two cents from me to discuss:
- when you're the first joined, shoud the waiting music be playing?
- when you're joining a 'voice room', should camera be enabled?
DorraJaouad
commented
Mar 25, 2026
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
from
April 3, 2026 12:50
13f01e7 to
ac209db
Compare
Antreesy
reviewed
Apr 7, 2026
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
from
April 8, 2026 08:48
ac209db to
2c84bea
Compare
Antreesy
approved these changes
Apr 8, 2026
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
2 times, most recently
from
April 8, 2026 19:21
8c0578b to
1817ba7
Compare
Antreesy
approved these changes
Apr 9, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
integration test failing is valid, frontend part is good.
Since you're rebasing anyway - please make joinCallAutomatically a separate commit. I'd like to backport it, feels like it can be useful in solving the breakout/extended rooms issue
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
from
April 9, 2026 13:04
1817ba7 to
83a0589
Compare
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
from
April 9, 2026 13:06
83a0589 to
be7a297
Compare
11 tasks
Antreesy
added a commit
that referenced
this pull request
Apr 14, 2026
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist