Skip to content

test(sharing): sort recipients before asserting in testGetShareWithPublicSecret - #62902

Merged
susnux merged 1 commit into
masterfrom
carl/fix-flaky-test
Aug 10, 2026
Merged

test(sharing): sort recipients before asserting in testGetShareWithPublicSecret#62902
susnux merged 1 commit into
masterfrom
carl/fix-flaky-test

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

The error in question

ApiV1ControllerTest::testGetShareWithPublicSecret with data set #0 (true)
  Failed asserting that two arrays are equal.
  --- Expected
  +++ Actual
  @@ @@
   Array (
  -    'class' => 'Test\Sharing\TestShareRecipientType1'
  -    'value' => 'recipient1'
  +    'class' => 'Test\Sharing\TestShareRecipientTypePublicSecret'
  +    'value' => 'recipient2'
       'instance' => null
  -    'display_name' => 'Recipient 1'
  +    'display_name' => 'Recipient 2'
       'icon' => [...]
       'secret' => Array (
           'updatable' => false
  +        'value' => '47BN3fes63WP0usnjUyF3pUYJh36RHMl'
  +        'url' => 'http://localhost/index.php/s/...36RHMl'
       )
       'initiator' => [...]
   )
  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan
CarlSchwan requested a review from a team as a code owner August 4, 2026 16:42
@CarlSchwan
CarlSchwan requested review from Altahrim, leftybournes, provokateurin and sorbaugh and removed request for a team August 4, 2026 16:42
@CarlSchwan CarlSchwan self-assigned this Aug 4, 2026
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 4, 2026
@CarlSchwan CarlSchwan added this to the Nextcloud 35 milestone Aug 4, 2026
@CarlSchwan

Copy link
Copy Markdown
Member Author

/backport to stable34

@CarlSchwan

Copy link
Copy Markdown
Member Author

/backport to stable33

…blicSecret

The error in question

```diff
ApiV1ControllerTest::testGetShareWithPublicSecret with data set #0 (true)
  Failed asserting that two arrays are equal.
  --- Expected
  +++ Actual
  @@ @@
   Array (
  -    'class' => 'Test\Sharing\TestShareRecipientType1'
  -    'value' => 'recipient1'
  +    'class' => 'Test\Sharing\TestShareRecipientTypePublicSecret'
  +    'value' => 'recipient2'
       'instance' => null
  -    'display_name' => 'Recipient 1'
  +    'display_name' => 'Recipient 2'
       'icon' => [...]
       'secret' => Array (
           'updatable' => false
  +        'value' => '47BN3fes63WP0usnjUyF3pUYJh36RHMl'
  +        'url' => 'http://localhost/index.php/s/...36RHMl'
       )
       'initiator' => [...]
   )
```

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwan force-pushed the carl/fix-flaky-test branch from 4b112f7 to 80046aa Compare August 7, 2026 12:29
@susnux
susnux merged commit 0c1c45b into master Aug 10, 2026
199 checks passed
@susnux
susnux deleted the carl/fix-flaky-test branch August 10, 2026 13:59
@backportbot

backportbot Bot commented Aug 10, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/62902/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 80046aae

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62902/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Aug 10, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/62902/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 80046aae

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62902/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants