Skip to content

fix(vue3): restore global t/n helpers on app instances #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pringelmann merged 1 commit into from
May 6, 2026
Merged

fix(vue3): restore global t/n helpers on app instances #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/GroupSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
</template>

<script>
import { t } from '@nextcloud/l10n'
import NcSelect from '@nextcloud/vue/components/NcSelect'

export default {
Expand All @@ -40,7 +41,7 @@
const defaultGroups = []
if (this.required && this.groups.length === 1) {
defaultGroups.push(this.groups[0])
this.$emit('input', defaultGroups.map((group) => group.gid))

Check warning on line 44 in src/components/GroupSelect.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The "input" event has been triggered but not declared on `emits` option
}
return {
selected: defaultGroups,
Expand All @@ -49,9 +50,13 @@

watch: {
selected() {
this.$emit('input', this.selected.map((group) => group.gid))

Check warning on line 53 in src/components/GroupSelect.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The "input" event has been triggered but not declared on `emits` option
},
},

methods: {
t,
},
}
</script>

Expand Down
3 changes: 3 additions & 0 deletions src/components/LanguageSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

<script>
import axios from '@nextcloud/axios'
import { t } from '@nextcloud/l10n'
import { generateOcsUrl } from '@nextcloud/router'
import NcSelect from '@nextcloud/vue/components/NcSelect'
import logger from '../utils/logger.ts'
Expand Down Expand Up @@ -60,6 +61,8 @@ export default {
},

methods: {
t,

async loadLanguages() {
try {
const result = await axios.get(generateOcsUrl('apps/guests/api/v1/languages'))
Expand Down
3 changes: 3 additions & 0 deletions src/views/GuestForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
import axios from '@nextcloud/axios'
import { showError, showSuccess } from '@nextcloud/dialogs'
import { emit } from '@nextcloud/event-bus'
import { t } from '@nextcloud/l10n'
import { generateOcsUrl } from '@nextcloud/router'
import { ShareType } from '@nextcloud/sharing'
import NcButton from '@nextcloud/vue/components/NcButton'
Expand Down Expand Up @@ -186,6 +187,8 @@ export default {
},

methods: {
t,

populate(metaData, shareWith) {
if (
shareWith
Expand Down
3 changes: 3 additions & 0 deletions src/views/GuestSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
<script>
import axios from '@nextcloud/axios'
import { showError } from '@nextcloud/dialogs'
import { t } from '@nextcloud/l10n'
import { generateUrl } from '@nextcloud/router'
import { clearTimeout, setTimeout } from 'timers'
import NcButton from '@nextcloud/vue/components/NcButton'
Expand Down Expand Up @@ -177,6 +178,8 @@ export default {
},

methods: {
t,

async loadConfig() {
const { data } = await axios.get(generateUrl('apps/guests/config'))
this.config = data
Expand Down
Loading