fix(vue3): restore global t/n helpers on app instances - #1551
Conversation
|
@skjnldsv this is still in draft, but please take a look so long if you have a minute |
|
Hey @pringelmann ! |
|
@skjnldsv sure thing, but the latest guests release is completely broken as a result of this regression. So can I suggest we merge this and I open a follow-up PR to register in each component? |
|
I started a copilot agent to work on this, I'll ping you in the PR |
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
27ec8fc to
8d7e6eb
Compare
|
@skjnldsv I've updated the PR with the correct fix. Would prefer to get this out as a clean patch asap if that's OK? (as opposed to it being rolled into a bigger PR) |
|
Yes and no, there are other issues needed to be fixed. |
|
@skjnldsv fair, will review the copilot PR so we can release everything together |
Resolves: #1547
Summary
GuestSettings,GuestForm,LanguageSelectandGroupSelectcallt()directly in their templates but neither importtnor expose it viamethodsafter the Vue 3 migration removed the globalNextcloud.jsmixin. The admin Guests page renders blank and the file Sharing "Invite guest" dropdown silently fails withTypeError: e.t is not a function.Import
tfrom@nextcloud/l10nin each affected SFC and register it on the component'smethodsso the template proxy can resolve it. Same per-component pattern already used inGuestList.vue,GuestDetails.vueandTransferGuestDialog.vue.Checklist
3. to review, feature component)stable32)