Skip to content

fix(vue3): restore global t/n helpers on app instances - #1551

Merged
pringelmann merged 1 commit into
mainfrom
fix/vue3-restore-globals
May 6, 2026
Merged

fix(vue3): restore global t/n helpers on app instances#1551
pringelmann merged 1 commit into
mainfrom
fix/vue3-restore-globals

Conversation

@pringelmann

@pringelmann pringelmann commented May 6, 2026

Copy link
Copy Markdown
Contributor

Resolves: #1547

Summary

GuestSettings, GuestForm, LanguageSelect and GroupSelect call t() directly in their templates but neither import t nor expose it via methods after the Vue 3 migration removed the global Nextcloud.js mixin. The admin Guests page renders blank and the file Sharing "Invite guest" dropdown silently fails with TypeError: e.t is not a function.

Import t from @nextcloud/l10n in each affected SFC and register it on the component's methods so the template proxy can resolve it. Same per-component pattern already used in GuestList.vue, GuestDetails.vue and TransferGuestDialog.vue.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

@pringelmann
pringelmann requested a review from skjnldsv May 6, 2026 07:50
@pringelmann

Copy link
Copy Markdown
Contributor Author

@skjnldsv this is still in draft, but please take a look so long if you have a minute

@pringelmann pringelmann self-assigned this May 6, 2026
@pringelmann pringelmann added bug Something isn't working regression Regression of a previous working feature high High priority 3. to review Waiting for reviews labels May 6, 2026
@skjnldsv

skjnldsv commented May 6, 2026

Copy link
Copy Markdown
Member

Hey @pringelmann !
The goal is to remove than antipattern. They should be registered on each component directly.

@pringelmann

Copy link
Copy Markdown
Contributor Author

@skjnldsv sure thing, but the latest guests release is completely broken as a result of this regression. So can I suggest we merge this and I open a follow-up PR to register in each component?

@skjnldsv

skjnldsv commented May 6, 2026

Copy link
Copy Markdown
Member

I started a copilot agent to work on this, I'll ping you in the PR

@skjnldsv

skjnldsv commented May 6, 2026

Copy link
Copy Markdown
Member

#1552 @pringelmann

-e
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the fix/vue3-restore-globals branch from 27ec8fc to 8d7e6eb Compare May 6, 2026 10:21
@pringelmann

Copy link
Copy Markdown
Contributor Author

@skjnldsv I've updated the PR with the correct fix. Would prefer to get this out as a clean patch asap if that's OK? (as opposed to it being rolled into a bigger PR)

@pringelmann
pringelmann marked this pull request as ready for review May 6, 2026 10:22
@skjnldsv

skjnldsv commented May 6, 2026

Copy link
Copy Markdown
Member

Yes and no, there are other issues needed to be fixed.

@pringelmann

Copy link
Copy Markdown
Contributor Author

@skjnldsv fair, will review the copilot PR so we can release everything together

@pringelmann
pringelmann merged commit f10f4f5 into main May 6, 2026
44 checks passed
@pringelmann
pringelmann deleted the fix/vue3-restore-globals branch May 6, 2026 12:10
@pringelmann pringelmann mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working high High priority regression Regression of a previous working feature

Projects

Development

Successfully merging this pull request may close these issues.

Update 4.7.0 does not work on NexlCloud AIO v12.9.2

2 participants