Skip to content

feat: add setting to allow guests to change their email - #1379

Merged
icewind1991 merged 1 commit into
mainfrom
guest-email-change-setting
Aug 15, 2025
Merged

feat: add setting to allow guests to change their email#1379
icewind1991 merged 1 commit into
mainfrom
guest-email-change-setting

Conversation

@icewind1991

@icewind1991 icewind1991 commented Aug 14, 2025

Copy link
Copy Markdown
Member
occ config:app:set guests allow_email_change --value true --type boolean --lazy

to enable

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Aug 14, 2025
@icewind1991
icewind1991 requested a review from skjnldsv August 14, 2025 17:26
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 14, 2025
@nc-enterprise-user

Copy link
Copy Markdown

Thank you for adding this flag.

If I may ask, are you aware of any specific concerns related to allowing Guests to change their email?

Is it just that there would be a disconnect between the Guest's static user ID and their email? Are there any other concerns related to Guests being able to change their emails or scenarios where there could be undesirable behavior?

We currently allow Guests to change their email, but the latest release makes me wonder if there could be considerations we are not aware of, or if it's just an administrative/organization preference.

Thank you, again.

@icewind1991

Copy link
Copy Markdown
Member Author

If I may ask, are you aware of any specific concerns related to allowing Guests to change their email?

The issue was mainly around confusion with the email being different, or in some cases empty. Nothing fundamental that I'm aware of.

@icewind1991
icewind1991 merged commit b32abf3 into main Aug 15, 2025
48 checks passed
@icewind1991
icewind1991 deleted the guest-email-change-setting branch August 15, 2025 08:40
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants