fix: prevent guests from changing their email address

[icewind1991]

Since guest are identified by their email, allowing users to change them is probably a bad idea.

[icewind1991]

And a repair step to fix cases where this was already changed: #1370

[nc-enterprise-user]

Please forgive me if this is not the right place to comment but this change has significant impact.

It is true that Guests are identified by their email, but it's also very common and natural that a user needs to update their email. This would then force any Guest email change to someone with administrative permissions and that is a lot of workload for networks with many Guest users.

Prior to this update, a Guest could update their own email and log in as either the initial email that was added, or the "primary" email in their profile.

I believe it is a significant functionality loss to not allow Guest users to be able to manage their own email and I appreciate you reading this view point. I am happy to provide more information if that is helpful.

Is there a conversation that discussed the primary concerns of Guests being able to change their emails?

[icewind1991]

#1379 adds a config flag